Stop moving Early FixedReg Use operands in certain conditions when Reuse operands are present.#190
Open
Iizerd wants to merge 2 commits intobytecodealliance:mainfrom
Open
Stop moving Early FixedReg Use operands in certain conditions when Reuse operands are present.#190Iizerd wants to merge 2 commits intobytecodealliance:mainfrom
Iizerd wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
whoopsies. double whoopsies.
… fixed def of the same PReg.
Member
|
I think the new logic makes sense. However, as with #180, which I see is included here as the first commit, could you extend the fuzzer to generate multiple reuse-input defs, and fuzz with that? |
Author
|
Yeah sorry about including #180 that again, I probably should have just put this commit in that same PR. This doesn't yet solve all the reason for that panic occurring, there is one more(at least?) I'm working on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the reasons for the panic at here is that
Early FixedReg Usesare having their position updated toLatewhen there is already aLate FixedReg Defor clobber of the fixedPReg. This fixes that by not moving the operand's position if one of these already exist.It's still possible to cause this behavior if a
Late DefoperandReuses anEarly FixedReg Def. However that is also easy to fix ifReuseoperands are checked to see if they reuse aFixedRegoperand.Thoughts? Am I missing something here? I ran the fuzzer overnight and compiled a few large binaries 200mb plus without fail; All run fine.